feat: decouple SM-2 algorithm, add timezone handling, and unit tests … - #1527
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description
Related Issue
Closes #1524
Summary
Extracted the
calculateSM2spaced repetition logic out of the flashcard controller and into a dedicated utility service (utils/srsAlgorithm.js). Introduced an optionaltimezoneparameter to the algorithm sonextDueDatecan accurately align with the start of the day (midnight) in the user's local timezone, rather than relying strictly on absolute server time. Finally, added a comprehensive Vitest unit testing suite to validate all repetition edge cases and timezone offsets.Type of Change
How Has This Been Tested?
again/hard/medium/easyrating boundaries, ease factor minimums, and timezone parsing (America/New_York,Australia/Sydney, etc.).npm run test/vitest) confirming 100% pass rate for the new algorithm logic.Screenshots (if applicable)
N/A - Backend logic and unit test refactor only.
Checklist